search

BKSalman / ytdlp-gui

a GUI for ytdlp written in Rust
GNU General Public License v3.0
222 stars 10 forks source link

upgrade to iced 0.9 + replace radio with pick_list #16

Closed BKSalman closed 11 months ago

BKSalman commented 11 months ago

somewhat addresses #15

BKSalman commented 11 months ago

@eclairevoyant could you review the changes? I replaced radio with a drop-down menu

eclairevoyant commented 11 months ago

Dropdown seems fine, though the gui itself is cut off:

image

It might be reporting a smaller size than it is intended to be; trimmed output from swaymsg -t get_tree below:

              "geometry": {
                "x": 0,
                "y": 0,
                "width": 738,
                "height": 561
              },
              "name": "ytdlp-gui",
BKSalman commented 11 months ago

though the gui itself is cut off

yes, it's kinda oversized on my machine, maybe related to scaling or something, will resolve that, and commit it

BKSalman commented 11 months ago

how about now? it looks fine on my machine now, hopefully on your machine too @eclairevoyant

BKSalman commented 11 months ago

ye I think this is fine, if it looks broken, people can report it to me