Outdated stylus conventions

BKWLD / create-cloak-app

Sets up a new Cloak (Nuxt + Craft/Contentful) based project.

MIT License

3 stars 0 forks source link

Outdated stylus conventions #79

Closed sjstark closed 2 years ago

sjstark commented 2 years ago

Screen Shot 2022-08-09 at 9 58 35 AM

It seems like we're using dated combinators somewhere within the package, which is leading to functionality not working perfectly (Can't seem to get layout mixins to work like +tablet-up())

weotch commented 2 years ago

I updated vue-ssr-carousel with a fix for this https://github.com/BKWLD/vue-ssr-carousel/pull/79. I'm not sure where else it's needed. I don't see either >>> or /deep/ in this package or in https://github.com/BKWLD/stylus-library. If you run across any instances in one of our packages, lemme know.

I wouldn't expect the breakpoint mixins to be affected by this...

weotch commented 2 years ago

Found another case: https://github.com/BKWLD/cloak-visual/pull/10

weotch commented 2 years ago

I think that was the last one, can no longer repro those warnings on https://github.com/BKWLD/bukwild.com