search

BKWLD / laravel-haml

Wraps MtHaml for ease use in Laravel
MIT License
45 stars 10 forks source link

L5 Support #16

Closed ghost closed 9 years ago

ghost commented 9 years ago

Hi Robert,

my first attempt to make it work on L5, works for me on my local machine.

Best

Julian

weotch commented 9 years ago

Thanks for this, gonna make some tweaks on top of it and tag it today.

ghost commented 9 years ago

Cool, thanks.

By the way, I created another library on top of yours:

https://github.com/trupedia/laravel-blade-haml

which extends the Blade Syntax style. Saw it in one of your issues. Hope you don't mind. If you need another form of Credit/acknowledgement please let me know.

Best

Julian

2015-04-15 0:05 GMT+02:00 Robert Reinhard notifications@github.com:

Thanks for this, gonna make some tweaks on top of it and tag it today.

— Reply to this email directly or view it on GitHub https://github.com/BKWLD/laravel-haml/pull/16#issuecomment-93084941.

weotch commented 9 years ago

Oh cool. Nah, you don't need to do anything special.

But if the two aren't mutually exclusive, why don't we add your functionality into mine so there is a just one goto HAML adapter for Laravel?

It looks like yours just extends the BladeCompiler ... is that all that was needed to get it working?

ghost commented 9 years ago

Great, sure we can do that. One place is better than two. Maybe we can work together on that repo then? Just couldn't wait for the PR to be merged, because I use the package in production for some small projects ;)

Yes, after some testing, it just was that easy :)

Am Mittwoch, 15. April 2015 schrieb Robert Reinhard :

Oh cool. Nah, you don't need to do anything special.

But if the two are mutually exclusive, why don't we add your functionality into mine so there is a just one goto HAML adapter for Laravel?

It looks like yours just extends the BladeCompiler ... is that all that was needed to get it working?

— Reply to this email directly or view it on GitHub https://github.com/BKWLD/laravel-haml/pull/16#issuecomment-93105413.

weotch commented 9 years ago

Ok, I've invited you to the team. You cool adding that other compiler for Blade, then?

ghost commented 9 years ago

Thanks. Yes, for sure. Should I do it or will you? Because if I do it, I will do it tomorrow. Here in germany it's nearly 2 o'clock in the morning ;)

2015-04-15 1:39 GMT+02:00 Robert Reinhard notifications@github.com:

Ok, I've invited you to the team. You cool adding that other compiler for Blade, then?

— Reply to this email directly or view it on GitHub https://github.com/BKWLD/laravel-haml/pull/16#issuecomment-93113998.

weotch commented 9 years ago

Oh damn, ha. Yeah, I'll throw it up right now. Go to bed!

ghost commented 9 years ago

Cool, thanks ;) I'll give it a look tomorrow then.

2015-04-15 1:43 GMT+02:00 Robert Reinhard notifications@github.com:

Oh damn, ha. Yeah, I'll throw it up right now. Go to bed!

— Reply to this email directly or view it on GitHub https://github.com/BKWLD/laravel-haml/pull/16#issuecomment-93115456.

ghost commented 9 years ago

Hi Robert,

found a bug while registering the extension for the Blade syntax. Have a commit waiting for this, but actually the team role doesn't include the repo that I can push it to the master branch ;)

Best

Julian

2015-04-15 1:45 GMT+02:00 Julian Karhoff j.karhoff@trupedia.de:

Cool, thanks ;) I'll give it a look tomorrow then.

2015-04-15 1:43 GMT+02:00 Robert Reinhard notifications@github.com:

Oh damn, ha. Yeah, I'll throw it up right now. Go to bed!

— Reply to this email directly or view it on GitHub https://github.com/BKWLD/laravel-haml/pull/16#issuecomment-93115456.

weotch commented 9 years ago

Ha ok, that's fixed now.

ghost commented 9 years ago

Great, pushed it. I'll check if it's now working properly in L5.

2015-04-15 18:08 GMT+02:00 Robert Reinhard notifications@github.com:

Ha ok, that's fixed now.

— Reply to this email directly or view it on GitHub https://github.com/BKWLD/laravel-haml/pull/16#issuecomment-93465367.