search

BKWLD / laravel-haml

Wraps MtHaml for ease use in Laravel
MIT License
45 stars 11 forks source link

Laravel Lumen Support #17

Open ghost opened 9 years ago

ghost commented 9 years ago

@weotch just tried to use the project with Lumen and the composer require works, because Lumen uses most of the L5 illuminate components. But registering the ServiceProvider of the package failed, because of the missing version constant in the Laravel\Lumen\Application.

What are your thoughts on this, should we enhance the package to support Lumen as well? Then we have one package to rule them all...

weotch commented 9 years ago

Yeah, sounds nice to support Lumen too. Yeah, maybe make the ->version() default to 5 if that constant doesn't exist. You down to do that?

ghost commented 9 years ago

If you don't mind, I'll try it out in another branch called "lumen", if the constant / version method is the only thing that needs to be adjusted. If it'll work we can merge it into master.

weotch commented 9 years ago

Noice

ghost commented 9 years ago

I tried it yesterday, but the issue is more complicated than only the version number. It's also an issue with the EngineResolver and registering the extensions. I have another look over the weekend to solve this.