search

BKWLD / vue-modal

A component that renders a modal window with slotted content. Includes trapped tabbing for ADA compliance
MIT License
1 stars 0 forks source link

Document how it's intended to be used (wrapped in transition) #3

Open mattaebersold opened 2 years ago

mattaebersold commented 2 years ago

It wasn't clear at first glance that I was intending this to be wrapped in a transition element with a v-show where you control that logic outside of vue-modal

weotch commented 2 years ago

Adding a demo using create-cloak-app would be 😘 👌 ... also, I think using v-if would be preferable to reduce the JS cost ... like so Vue doesn't do any work until the modal is actually opened.