BL-Labs / imagedirectory

Manifests of the public domain images uploaded to Flickr Commons, with descriptive information about the books they were taken from.
The Unlicense
73 stars 19 forks source link

Add (original, large, medium, small) image URLs for all 1M photos #7

Closed straup closed 10 years ago

straup commented 10 years ago

This pull request adds original (and other) image URLs for all 1M photos in the British Library Flickr Commons manifest. The following modifies all the .tsv files to include the following keys:

Arguably this is overkill and causes unnecessary bloat because:

I did not do any of these things since they are all changes that can be applied to the current patch if needed and because they impose a extra layer of understanding and potentially programming in order to use the data dump to fetch an individual photo.

Note: If past experience is any guide there are probably too many changes for a pull request of this size to be merged in the GitHub web application. If this pull request is merged it will likely need to happen from the command line.

Cheers,

benosteen commented 10 years ago

Brilliant! Thanks greatly for this, it was a task I wasn't looking forward to doing when I got back into the office!