search

BLAKE2 / libb2

C library providing BLAKE2b, BLAKE2s, BLAKE2bp, BLAKE2sp
Creative Commons Zero v1.0 Universal
132 stars 47 forks source link

REPLACE EXPORT_DLL WITH BLAKE2_API #1

Closed BurningEnlightenment closed 8 years ago

BurningEnlightenment commented 8 years ago

Export symbols as recommended by the https://gcc.gnu.org/wiki/Visibility Step-by-Step Guide.

The symbols EXPORT_DLL, DYNAMIC_LIB_EXPORT and DYNAMIC_LIB are way too generic and will likely cause name clashes if libb2 is used within a larger project which imports multiple external libraries.

sneves commented 8 years ago

This looks good, thanks. Can you further replace _DLL_IMPORT by BLAKE2_DLL_IMPORT, along with the other 2 similar macros? These definitions are in the main include file, and may also cause collisions when included along other libraries.

BurningEnlightenment commented 8 years ago

Can you further replace _DLL_IMPORT by BLAKE2_DLL_IMPORT, along with the other 2 similar macros? These definitions are in the main include file, and may also cause collisions when included along other libraries.

@sneves I fixed it.