Fix build for big endian AArch64 hosts

BLAKE3-team / BLAKE3

the official Rust and C implementations of the BLAKE3 cryptographic hash function

Apache License 2.0

5.02k stars 341 forks source link

Fix build for big endian AArch64 hosts #336

Closed kovdan01 closed 11 months ago

kovdan01 commented 1 year ago

Implementation only supports using arm neon for little endian hosts, while the corresponding BLAKE3_USE_NEON macro is set for all AArch64 hosts unconditionally. This causes a build error: see https://github.com/BLAKE3-team/BLAKE3/blob/master/c/blake3_neon.c#L6. Submitted a PR fixing this behavior: https://github.com/BLAKE3-team/BLAKE3/pull/335

ThomasWaldmann commented 11 months ago

You made me curious: what kind of hosts and OSes are there for big-endian aarch64?

kovdan01 commented 11 months ago

I can't say for sure :) I was checking this "just in case" as a part of another project to ensure that code works properly for both endiannesses, and I have chosen aarch64 BE since a prebuilt cross-toolchain was available for it.

kovdan01 commented 11 months ago

Close as fixed in https://github.com/BLAKE3-team/BLAKE3/pull/280