Silence gcc -Wunused-function

BLAKE3-team / BLAKE3

the official Rust and C implementations of the BLAKE3 cryptographic hash function

Apache License 2.0

5.06k stars 346 forks source link

Silence gcc -Wunused-function #381

Closed divinity76 closed 8 months ago

divinity76 commented 8 months ago

gcc on MacOS-ARM64 may error out with

/Users/runner/work/php-src/php-src/ext/hash/blake3/upstream_blake3/c/blake3_dispatch.c:112:5: error: unused function 'get_cpu_features' [-Werror,-Wunused-function]

full compiler log https://github.com/php/php-src/actions/runs/7762643678/job/21173438425?pr=13194

the optimal fix would be to make sure get_cpu_features() is only compiled on platforms where it is used, but that would take more effort (have not investigated how much effort that would be)

divinity76 commented 8 months ago

nevermind, thought of a better way to solve it: https://github.com/BLAKE3-team/BLAKE3/pull/382