search

BLAKE3-team / BLAKE3

the official Rust and C implementations of the BLAKE3 cryptographic hash function
Apache License 2.0
4.71k stars 315 forks source link

Support running inside miri #387

Closed ryoqun closed 3 months ago

ryoqun commented 3 months ago

hi :)

As the title just says, this pr adds minimal support for running under miri.

I wonder this pr could be merged without much hassle from me like enhancing ci... ;)

oconnor663 commented 3 months ago

Thanks! I've followed up with 2435e29dbe57724ab3ae02fc5ea2a9cb83009f89 and d57818afdcf9715aafb1eaf30a34c6fffdb6eed0 to get cargo +nightly miri test working. It takes forever though, so I probably won't add it to CI :sweat_smile:

oconnor663 commented 3 months ago

CI integration: 5b9af1c34746e20b4596c1812b683624bdcfc152

ryoqun commented 3 months ago

@oconnor663 hey, really thanks for polishing the miri support. now that it's minimally covered even by ci, i have to ask you: why not 1.5.1? :) Thanks in advance.

oconnor663 commented 3 months ago

Good call, done.