search

BLAKE3-team / BLAKE3

the official Rust and C implementations of the BLAKE3 cryptographic hash function
Apache License 2.0
5.22k stars 351 forks source link

build(windows): add support for gnullvm targets #399

Closed ognevny closed 4 months ago

ognevny commented 5 months ago

there are 2 types of non-msvc windows targets: -pc-windows-gnu and -pc-windows-gnullvm. gnullvm targets based on llvm-mingw (clang toolchain in fact)

oconnor663 commented 4 months ago

Today I learned! Could you add a comment to this PR to help me remember next time I look at this line of code? :)

ognevny commented 4 months ago

Could you add a comment to this PR to help me remember next time I look at this line of code? :)

yes, but when?

oconnor663 commented 4 months ago

Sorry I meant like an inline comment in build.rs right above your change, reminding me/everyone to think about gnullvm when we change this code.

ognevny commented 4 months ago

Sorry I meant like an inline comment in build.rs right above your change, reminding me/everyone to think about gnullvm when we change this code.

ok, will add tomorrow

ognevny commented 4 months ago

sorry for delay, I forgot about it! added a comment

oconnor663 commented 4 months ago

Thanks!