search

BLAKE3-team / BLAKE3

the official Rust and C implementations of the BLAKE3 cryptographic hash function
Apache License 2.0
5.23k stars 353 forks source link

build(CMake): Fix pkg-config for absolute CMAKE_INSTALL_*DIR #426

Closed fgaz closed 1 month ago

fgaz commented 2 months ago

CMAKEINSTALL*DIR can be absolute, and in that case ${prefix} should not be prepended.

See https://github.com/jtojnar/cmake-snips/?tab=readme-ov-file#concatenating-paths-when-building-pkg-config-files

fgaz commented 1 month ago

Is there anything I can do to move this forward?

BurningEnlightenment commented 1 month ago

If @oconnor663 doesn't say no until Friday, I'll go ahead and merge this. I don't think that his review is strictly necessary in this case.

fgaz commented 1 month ago

friendly ping

BurningEnlightenment commented 1 month ago

Thanks!