search

BLE-LTER / MetaEgress

R package to create Ecological Metadata Language documents from an instance of LTER-core-metabase database schema
https://BLE-LTER.github.io/MetaEgress/
6 stars 3 forks source link

in get_meta.r, consider separating configurable sections from main function #41

Open mobb opened 5 years ago

mobb commented 5 years ago

An - this is great! and so easy to read! I have a suggestion: some of the components in the main function seem like they could be set outside of the function and then passed in. In particular: con <-dbConnect( ... views_expected <- c(... names_short <- c( ...

I think they would be easier to keep up to date that way.

atn38 commented 5 years ago

Hello Margaret, thanks for the suggestions! I've been working gradually towards breaking up the functionality. I'd need to delve a bit deeper to see if there's a method to break up into component vectors as you suggest as well, since I'm more familiar with breaking up functions. Have you tried the other functions in the package?

On Fri, Aug 23, 2019 at 7:30 PM mobb notifications@github.com wrote:

An - this is great! and so easy to read! I have a suggestion: some of the components in the main function seem like they could be set outside of the function and then passed in. In particular: con <-dbConnect( ... views_expected <- c(... names_short <- c( ...

I think they would be easier to keep up to date that way.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/BLE-LTER/MetaEgress/issues/41?email_source=notifications&email_token=AKAZD5RM5Y4XVURJVYCPYF3QGB6KPA5CNFSM4IPET4YKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HHEZ45Q, or mute the thread https://github.com/notifications/unsubscribe-auth/AKAZD5XWTFVNTOUHQB44BMLQGB6KPANCNFSM4IPET4YA .