BLeeEZ / amperfy

Amperfy is an iOS app to play songs from an Ampache or Subsonic server
GNU General Public License v3.0
384 stars 34 forks source link

[Feature] Include favourite status in track list row. #208

Closed Karta775 closed 4 months ago

Karta775 commented 5 months ago

I really like the app but something I miss from Spotify is favourite status. It would be great to have the ability to see at a glance which songs in my library, search results, or in an album are favourited.

I made a mockup of what I mean:

I poked around the code a bit and saw that track duration has been added to the track list row at the trailing edge where I placed the favourite indicator. Since duration will be toggleable, could this also be toggleable? Or allow the user to choose between duration & favourite status with a picker?

The "Favourite Songs" list should probably not contain favourite indicators since it's redundant there.

Thanks, this is truly the best way to use Navidrome on iOS :)

BLeeEZ commented 5 months ago

I think this is a great feature. I need to find a solution, as you mentioned, how to handle duration and "is favourite" icon. Mutual exclusivity or display both. This needs to be tested. Should this be possible only for songs or for albums/artists too?

Karta775 commented 5 months ago

I hadn't thought about albums and artists, but that would be great too!

BLeeEZ commented 5 months ago

What do you think about this approach? This is the way Apples Music App displays favourite songs.

Bildschirmfoto 2024-01-11 um 12 12 31
Karta775 commented 5 months ago

That looks great!

BLeeEZ commented 5 months ago

This feature can be tested in v1.1.5 (2). It is now available as Beta via TestFlight: https://github.com/BLeeEZ/amperfy/issues/25

Karta775 commented 5 months ago

I've installed the latest beta and it's perfect. Thanks again :)