Theme: add theme colors

BLeeEZ / amperfy

Amperfy is an iOS app to play songs from an Ampache or Subsonic server

GNU General Public License v3.0

383 stars 34 forks source link

Theme: add theme colors #266

Closed danielepintore closed 2 weeks ago

danielepintore commented 3 weeks ago

This pull request adds themes to the app, since this is my first time doing a IOS contribution it would be nice to have someone double check the changes. I have tested these changes on a iphone and ipad, i can't test it on a apple carplay.

BLeeEZ commented 3 weeks ago

First of all thank you for your contribution. I will need some time to review your request. Adding a selectable theme sounds like a great enhancement. Thank you.

danielepintore commented 3 weeks ago

Thank you for your wonderful work on the app! When you review my pull request let me know if there is something that needs some changes.

BLeeEZ commented 2 weeks ago

Really great work. I did some adjustments to your provided code:

provide theme color to artworks explicit
change color without Amperfy to restart
rename some variables
use for CarPlay too

Thank you very much for your contribution. I will merge is to develop branch since I want to release this bigger feature in the next version v1.2.2.