BLeeEZ / amperfy

Amperfy is an iOS/iPadOS/macOS app to play songs from an Ampache or Subsonic server
GNU General Public License v3.0
515 stars 40 forks source link

[Bug] Disabling haptic feedback has no effect #283

Open BLeeEZ opened 5 months ago

BLeeEZ commented 5 months ago

@brokoler: please create for bugs and feature request separate tickets. It makes it easier for me to keep track of progression and makes discussions easier.

Minor issue: Disabling haptic feedback in latest beta has no effect, haptic feedback is active all the time.

BLeeEZ commented 5 months ago

This option deactivates vibration for "Play" and "Shuffle" buttons. These vibrations are triggered and controlled by Amperfy itself. Some interactions are done by iOS (e.g. long press to show preview), these can't be deactivated. Which interactions are you referring to, that still lead to vibration even when the option is deactivated?

brokoler commented 5 months ago

Sorry for the circumstances!

Tested haptic feedback with both options and didn't recognize a difference. The long press vibration is intended based on system level, understood and familiar from other apps. When pressing the "Play" or "Shuffle" buttons there is no vibration at all, no matter if the option is enabled or disabled.

Some situations where I recognized a vibration with the setting being off:

In these cases I expected there would be a difference when the vibration setting is disabled. Recognized that because I enabled vibration on a system level and normally like the haptic feedback, using Amperfy feels very haptic to me so I tried to disable the vibrations.

Just a minor issue for sure!

danielepintore commented 5 months ago

Hi, I've worked on the feature, when you disable the haptic feedback you disable the vibration when you click a song in the Songs list, or when you click a song in the album view. Indeed the toggle doesn't affect the situations that you have listed. @BLeeEZ should consider if we should expand the toggle functionality for those situations.