BLlakers / 2024_Official

Other
2 stars 1 forks source link

Commenting step 1 #39

Open jforchheimer25 opened 2 months ago

jforchheimer25 commented 2 months ago

Pull Request for Commenting Branch

dlezcan1 commented 2 months ago

@jforchheimer25 Thread here: I believe the structure of an abstract static class is more confusing than just using standard comment blocks for all functions and classes

dlezcan1 commented 2 months ago

When people want explanation for things I would like for everything to be in the same place

@jforchheimer25 Then you can do that 1 of two ways. 1: A separate .java file with comment block descriptions, or a README.md file which connects all of these together. A class with arbitrary functions which return arbitrary integers is confusing and clunky. It's sleeker to stick to comment blocking

dlezcan1 commented 2 months ago

What about command Scheduler etc. I want to make it so that each student who wants to code after me knows exactly where to look for stuff. I cant java doc the init sendable stuff really and command scheduler stuff

This can be commented where it is implemented. We could have a separate function on each and link them to the web pages with our simpler explanation

jforchheimer25 commented 2 months ago

This can be commented where it is implemented. We could have a separate function on each and link them to the web pages with our simpler explanation

could you show an example?

dlezcan1 commented 2 months ago

Here is an example for Python of good structured commenting:

https://github.com/PhotonVision/photonvision/blob/master/photon-lib/py/photonlibpy/photonPoseEstimator.py

jforchheimer25 commented 2 months ago

Here is an example for Python of good structured commenting:

https://github.com/PhotonVision/photonvision/blob/master/photon-lib/py/photonlibpy/photonPoseEstimator.py

Ill Remove the class later then. Im more focused on getting the explanations in first.

dlezcan1 commented 2 months ago

Sure, but keep new additions to be class-based and function-based. No need for the Explanation functions.