donhinkelman
commented
6 months ago Hi Dan, thanks so much for carefully reviewing our code and giving absolutely valuable advice for improving it. Brendon, Matt and I (university teachers in Japan) have been developing this application for over 12 years and using freelance programmers from all over the world to do the performance assessment activities that work in our classrooms. We love this plugin and it now works well for students on their mobile phones to do self and peer assessment using rubrics. However, after many years and many requests to make the code public, we released it last week. Your comments are a wake-up call to pay attention to good coding conventions and we'll have to figure out a way to do that--as we do not have any programming skills. We will get some funding in April, and if you all can wait that long, we will ask our programmers to do all the fixes you request. Or maybe you know some interns or volunteers who could handle this easily in the next few weeks. Thanks again for the careful attention and time you have spent on this.
sapporomatt
danmarsden
BM373
Some of the tests run by the Moodle.org plugins db can be run via github actions on each commit in your github repo. Enabling this helps you to make sure future changes to your plugin will continue to follow the guidelines.
the short version - grab this file: https://github.com/moodlehq/moodle-plugin-ci/blob/master/gha.dist.yml rename it as ci.yml and put into the directory .github/workflows within tyour project eg: https://github.com/danmarsden/moodle-mod_attendance/blob/MOODLE_311_STABLE/.github/workflows/ci.yml
then on every commit you make to github it will fire off a request to run the tests and will give you traffic lights beside each commit and generate a report.