BM373 / moodle-mod_videoassessment

VAM - Video Assessment Module Moodle plugin
1 stars 3 forks source link

raw access to $_GET/$_POST/$_REQUEST is not allowed #22

Open danmarsden opened 6 months ago

danmarsden commented 6 months ago

https://github.com/BM373/moodle-mod_videoassessment/blob/40bd5a043e0cfffc2826583ffdc51947736bbbb3/assignclass/index.php#L17-L20

Please use moodle's optional/required_param apis this is a blocker for plugins db approval.

more info on this here: https://moodledev.io/general/development/policies/security#dont-trust-any-input-from-users

danmarsden commented 6 months ago

please review all your code to ensure you fix - not just the example I gave above.