Fixed mph not working for valley

BMClab / BMC

Notes on Scientific Computing for Biomechanics and Motor Control

https://bmclab.github.io/BMC/

Creative Commons Attribution 4.0 International

435 stars 265 forks source link

Closed rajathkmp closed 6 years ago

rajathkmp commented 8 years ago

Since x = -x in the start itself, the mph when given was not finding the peaks for minimum height.

Should be updated in the Jupiter notebook also

demotu commented 6 years ago

I think the proper way to correct this bug is by inverting the sign of mph if parameter valley is True. See version 1.05.