search

BMDan / tuning-primer.sh

MySQL Tuning-Primer.sh, updated and improved
GNU General Public License v2.0
497 stars 116 forks source link

feat: support remote hosts, add warning #15

Closed BMDan closed 3 years ago

BMDan commented 3 years ago

Closes #13

Let's just say that this PR was a long walk down a very, very dirty road.

@chrislp give it a try, please?

chrislp commented 3 years ago

It works! Thanks, @BMDan !

Now I have to deal with a badly configured database 🙈

BMDan commented 3 years ago

@chrislp Thanks for the review. I'm sure you don't need it, but a general reminder to anyone who finds this PR later that the script reads data from the host on which it's running for crucial things like amount of memory in the machine--which, of course, is not going to be accurate if you're connecting to a remote MySQL instance.

In other words: please don't follow any suggestions without considering how they were generated, and in the case of a remote target, whether they relied on information not sourced through the MySQL client protocol.