search

BMILAB / scAPAtrap

GNU Affero General Public License v3.0
15 stars 7 forks source link

There is one mistake I think #2

Open cb11711211 opened 3 years ago

cb11711211 commented 3 years ago

For function generatescExpMa , there is a param called d, which is not used in your function and with no related info. I think that would be type mistake.

cb11711211 commented 3 years ago

And that function must process with the param d, and I set 2 and 1 and there is no change for the output of this function. And in your source code, d is not used at all.

mfansler commented 1 year ago

I believe the d is used to set the radius within which to search for cleavage sites that can match to the 3' end of the peak. See

https://github.com/BMILAB/scAPAtrap/blob/12ee8f5df34fbe81642fe8564132e3f847f93132/R/scAPAtrap_funlib.R#L478

The default for the function they pass it to is 100, so maybe that should be a default for generatescExpMa. Either that, or pass this parameter via an ... argument.