search

BMSVieira / BVSelect-VanillaJS

BVSelect - Vanilla Javascript Fully Customizable SelectBox
MIT License
117 stars 16 forks source link

Dynamicly creation option elements breaks when value contain spaces #14

Open AforDesign opened 1 year ago

AforDesign commented 1 year ago

When option elements are created dynamicly, the values need to be encapsulated. Right now, this is not the case, resulting in broken html when values contain spaces.

To fix this, change:

                document.getElementById(this.selector).insertAdjacentHTML('beforeend',
                    "<option "+change_img+" "+change_icon+" "+change_separator+" "+change_disabled+" value="+properties.options[i].value+" >"+properties.options[i].inner_text+"</option>");

To:

                document.getElementById(this.selector).insertAdjacentHTML('beforeend',
                    "<option "+change_img+" "+change_icon+" "+change_separator+" "+change_disabled+" value=\""+properties.options[i].value+"\" >"+properties.options[i].inner_text+"</option>");