search

BNETDocs / packet-bnetp

Classic Battle.net and Classic Blizzard Games Packet Dissector for Wireshark
GNU General Public License v3.0
14 stars 3 forks source link

Fix BNFTP protocol detection #1

Open cen1 opened 7 years ago

carlbennett commented 7 years ago

It is already semi-aware of BNFTP: https://github.com/BNETDocs/packet-bnetp/blob/4c7ae583988cea997242cd9b4623b769944b6f0c/src/packet-bnetp.lua#L66-L72

It just needs to be fixed.

carlbennett commented 7 years ago

More specifically, it correctly identified ver-IX86-5.mpq as FTP_PROTOCOL (BNFTP), however it did not identify icons-WAR3.bni as such.

cen1 commented 7 years ago

It is aware of bnftp yes but it does not have the protocol implementation, just detects the header. It needs to be implemented for bnftp v1 and v2. I'll give it a go.