search

BNFC / bnfc

BNF Converter
http://bnfc.digitalgrammars.com/
586 stars 165 forks source link

#198 use stack to build bnfc #199

Closed pascalh closed 5 years ago

pascalh commented 7 years ago

This pull request is associated to issue #198 and is just a preview, thus not yet ready for merge. However, building bnfc with stack and running the tests should be working (not all tests may succeed due to missing tool setup). Consider the pr as a basis for discussion.

Before merging this pull request in master the following things may need to be updated:

gdetrez commented 7 years ago

On the other hand we could setup the stack based build and talk about the system tests after that.

That's a good idea. I can already see advantages in being able to build bnfc with stack even without the system tests. We can see about running system tests with stack later, maybe once there is a new build server.

pascalh commented 7 years ago

With this setup the following things work (and everything related to our old build using cabal is completely untouched):

stack setup 
stack build
stack test
cd testing/
stack exec bnfc-system-tests

I wanted to share this even if one has to enter the directory testing to run the system tests. Edit: I have actually no idea why the travis is failing.

bafain commented 5 years ago

Thanks for your commit c35ba97 ([#198]added bnfc-wide stack file). It just got rebased and merged into master as commit 3b6a007, with an updated LTS version. Please consider closing this pull request.

andreasabel commented 5 years ago

Thanks, everyone! I am closing this, as stack-*.yaml files are now present.