BNFC / bnfc

BNF Converter
http://bnfc.digitalgrammars.com/
586 stars 165 forks source link

Fix rule for token position example #211

Closed mluszczyk closed 6 years ago

mluszczyk commented 6 years ago

The sample rule for CIdent has a "|" in it by mistake. The error makes CIdent accept empty strings which causes problems and raises the following warning:

Warning : The following tokens accept the empty string: CIdent This is error-prone and will not be supported in the future.

mluszczyk commented 6 years ago

Please also update the "BNF Converter Tutorial" page (http://bnfc.digitalgrammars.com/tutorial.html). The following line appears there:

position token CIdent (letter | (letter | digit | '_')*) ;
andreasabel commented 6 years ago

Thanks again!

I fixed it in the repo.

I am not sure how to update the web page though. This is maintained by Aarne's company.

@Aarne, Thomas: over to you!

Best, Andreas

On 15.11.2017 09:57, Michał Łuszczyk wrote:

Please also update the "BNF Converter Tutorial" page (http://bnfc.digitalgrammars.com/tutorial.html). The following line appears there:

|position token CIdent (letter | (letter | digit | '_')*) ; |

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/BNFC/bnfc/pull/211#issuecomment-344527311, or mute the thread https://github.com/notifications/unsubscribe-auth/ABGgkpxVha8ZzDl3l1gcR5aeBECfB9Bpks5s2qeFgaJpZM4QU6iP.

-- Andreas Abel <>< Du bist der geliebte Mensch.

Department of Computer Science and Engineering Chalmers and Gothenburg University, Sweden

andreas.abel@gu.se http://www.cse.chalmers.se/~abela/