static pointers to array position in dashboard.js

[jdeck88]

Referencing values for bd/bsal use static pointers to array position. See comment from recent commit https://github.com/BNHM/AmphibiaWebDiseasePortal/commit/c647bde28779630af0952b24891d9d0badef7bd8

The return value of Bd and Both reference "NO_CONFIDENCE" array values instead of "TRUE". this was hard to tell since references pointed to array position [0/1] instead of actual value. This commit is a temporary fix to point to TRUE for these instances but code should be fixed later... i will make an issue for this.

[birbjam]

I will take a look! @jdeck88 do you know which json this is fetching from?

[birbjam]

Ok so it's fetching from here. https://github.com/BNHM/AmphibiaWebDiseasePortalAPI/blob/master/data/diseaseDetected_Bd.json

@mkoo how should this be displayed?

[jdeck88]

instead of:

${bothDetectedValue[2]}

something like:

${bothDetectedValue['TRUE']}

not sure if huge/javascript uses associative arrays, but you get the point. array position 2 can't reliably be mapped to that position on the array indicating TRUE

John

[birbjam]

Ok that's for True and False, what about the other two: Unknown and No_Confidence? Should I omit those from the table or no?

[jdeck88]

I think a good idea to put those in the table as well... that way all the numbers should add up and good to show the users that this data exists.. we could always comment out those rows later if Michelle doesn't want to see them but better to have everything add up rather than have mysteriously missing data.

[mkoo]

Agreed. the two values-- unknown and no_confidence-- do have slightly different connotations. Let the user decide to keep or filter out

On Mon, Sep 6, 2021 at 10:32 AM John Deck @.***> wrote:

I think a good idea to put those in the table as well... that way all the numbers should add up and good to show the users that this data exists.. we could always comment out those rows later if Michelle doesn't want to see them but better to have everything add up rather than have mysteriously missing data.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/BNHM/AmphibiaWebDiseasePortal/issues/129#issuecomment-913785317, or unsubscribe https://github.com/notifications/unsubscribe-auth/AATH7UL6AXBY5LIZBAQUHLLUAT3LHANCNFSM5DQWE3JA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[birbjam]

Great, I'll set it up.