search

BNHM / ecoreader

Publish, visualize, and query field notebook data from source collections
http://ecoreader.berkeley.edu
Other
3 stars 3 forks source link

Geography search #53

Closed ccicero closed 7 years ago

ccicero commented 7 years ago

The new Geographic search function is great, thanks for implementing! Michelle said that it is parsing out the data from the section headings, is that correct? Shouldn't it only return those sections with that geography? e.g., I searched on "North America, Mexico, Baja California" and it returned a lot of notes that are not from Baja. See attached screen shot.

image

jdeck88 commented 7 years ago

I'm not sure this is a bug. The geographic search looks at section geographies but results are always returned by the volume. The volume itself may contain references to other sections, e.g. in the index or perhaps other sections that may precede in time or space the returned result that could be of interest. At any rate, if we do decide to return just sections as a result do we want to make this the default for all queries (e.g. for queries based on author name)? or, just queries based on geography? what about queries based on both geography and author name?

ccicero commented 7 years ago

Christina explained where the data are coming from and that it's at the volume level. I think we at least need a little "i" icon with a pop-up window that explains that not all of the volumes have higher geography data populated yet, and that the query returns the entire volume even if just one section has that higher geography. Is that possible? Thanks.

jdeck88 commented 7 years ago

So, an "i" icon placed after Geography like: unnamed

jdeck88 commented 7 years ago

This issue covers #54 so will be closing that one.

ccicero commented 7 years ago

Yes, an "i" icon like in that image. Thanks.