BNL-DAQ-LDRD / NeuralCompression

3 stars 2 forks source link

Refactoring BCAE models #5

Closed YHRen closed 2 years ago

YHRen commented 3 years ago
pphuangyi commented 2 years ago

Hi Ray, I found out that the code becomes more succinct and readable if when constructed BCAE anew from the blocks in blocks.py instead of making it an inherited class of CAE. So I am wondering whether can skip the inheritance part but make BCAE standalone.

YHRen commented 2 years ago

Yes. Feel free to submit a PR and we can do a code review together.

YHRen commented 2 years ago

9 close