Closed YHRen closed 2 years ago
Hi Ray, I found out that the code becomes more succinct and readable if when constructed BCAE anew from the blocks in blocks.py
instead of making it an inherited class of CAE. So I am wondering whether can skip the inheritance part but make BCAE standalone.
Yes. Feel free to submit a PR and we can do a code review together.
bcae.py
into three files:blocks.py
,bcae.py
andcae.py
blocks.py
, and removeget_
prefix.CNNencoder
andCNNDecoder
andCNNAE
(withsingle=True
logic path) tocae.py
BCAE
inheritates fromCNNAE
, and add thesingle=False
logic path in__init__
andforward
.blocks.py