search

BNLNPPS / esi-g4ox

0 stars 0 forks source link

build: add basic workflow to build PRs #31

Closed plexoos closed 1 month ago

plexoos commented 1 month ago

Using esi-shell container

Added a basic test comparing photon histories for GPU and CPU based simulations.

plexoos commented 1 month ago

8 out of 100 photons have significantly different histories cc @ggalgoczi

ggalgoczi commented 1 month ago

I found errors in the raindrop model. I am not sure this is because of that. When I tried to use CaTS for raindrop on GPU it did not work until I corrected the optical surface. Will propose a fix to the model today.

plexoos commented 1 month ago

Thank you Gabor! It would be nice to see if the issue can be reproduced with our tools, feel free to create an issue