BNUACM / bnuoj-backend

Backend service for BNUOJ (Judger and Dispatcher)
GNU Affero General Public License v3.0
10 stars 9 forks source link

Change Bott to JSON. #7

Closed 51isoft closed 9 years ago

51isoft commented 9 years ago

Review on Reviewable

crccw commented 9 years ago

Review status: 0 of 4 files reviewed, 11 unresolved discussions, all commit checks successful.


dispatcher-v2/Bott.cpp, line 25 [r1] (raw file): No longer needed


dispatcher-v2/Bott.cpp, line 44 [r1] (raw file): No longer needed


dispatcher-v2/Bott.cpp, line 48 [r1] (raw file): do we have to check HasParseError() here?


dispatcher-v2/Bott.cpp, line 124 [r1] (raw file): Pass v by reference?


dispatcher-v2/Bott.cpp, line 130 [r1] (raw file): ditto


dispatcher-v2/Bott.h, line 226 [r1] (raw file): No longer needed


dispatcher-v2/Bott.h, line 253 [r1] (raw file): No longer needed


dispatcher-v2/Bott.h, line 258 [r1] (raw file): No longer needed


judger-v2/Bott.cpp, line 30 [r1] (raw file): No longer needed


judger-v2/Bott.h, line 365 [r1] (raw file): No longer needed


judger-v2/Bott.h, line 370 [r1] (raw file): No longer needed


Comments from the review on Reviewable.io

51isoft commented 9 years ago

Review status: 0 of 4 files reviewed, 11 unresolved discussions, all commit checks successful.


dispatcher-v2/Bott.cpp, line 25 [r1] (raw file): Done.


dispatcher-v2/Bott.cpp, line 44 [r1] (raw file): Done.


dispatcher-v2/Bott.cpp, line 48 [r1] (raw file): Well, we are guaranteed to have JSON here, so, I would say no :)


dispatcher-v2/Bott.cpp, line 124 [r1] (raw file): We are using InttoString to create temporary string, so cannot use reference.


dispatcher-v2/Bott.cpp, line 130 [r1] (raw file): ditto


dispatcher-v2/Bott.h, line 226 [r1] (raw file): Done.


dispatcher-v2/Bott.h, line 253 [r1] (raw file): Done.


dispatcher-v2/Bott.h, line 258 [r1] (raw file): Done.


judger-v2/Bott.cpp, line 30 [r1] (raw file): Done.


judger-v2/Bott.h, line 365 [r1] (raw file): Done.


judger-v2/Bott.h, line 370 [r1] (raw file): Done.


Comments from the review on Reviewable.io