Closed crccw closed 9 years ago
Reviewed files:
vjudge-v2/GlobalHelpers.cpp, line 230 [r1] (raw file): space
vjudge-v2/GlobalHelpers.cpp, line 232 [r1] (raw file): expand lines
vjudge-v2/GlobalHelpers.cpp, line 235 [r1] (raw file): case '\n'?
vjudge-v2/GlobalHelpers.cpp, line 351 [r1] (raw file): spaces
vjudge-v2/GlobalHelpers.h, line 44 [r1] (raw file): sha1String/getSha1ForString
vjudge-v2/UESTCJudger.cpp, line 21 [r1] (raw file): "Custom" Why do we need to customize this?
vjudge-v2/UESTCJudger.cpp, line 171 [r1] (raw file): nit: no newline
vjudge-v2/UESTCJudger.h, line 2 [r1] (raw file): spaces
vjudge-v2/UESTCJudger.h, line 21 [r1] (raw file): spaces
Comments from the review on Reviewable.io
vjudge-v2/GlobalHelpers.cpp, line 230 [r1] (raw file): Done.
vjudge-v2/GlobalHelpers.cpp, line 232 [r1] (raw file): Done.
vjudge-v2/GlobalHelpers.cpp, line 235 [r1] (raw file): Done.
vjudge-v2/GlobalHelpers.cpp, line 351 [r1] (raw file): Done.
vjudge-v2/GlobalHelpers.h, line 44 [r1] (raw file): Done.
vjudge-v2/UESTCJudger.cpp, line 21 [r1] (raw file): mentioned in the commit log UESTC requires ContentType in header
vjudge-v2/UESTCJudger.h, line 2 [r1] (raw file): Done.
vjudge-v2/UESTCJudger.h, line 21 [r1] (raw file): Done.
Comments from the review on Reviewable.io
vjudge-v2/UESTCJudger.h, line 21 [r1] (raw file): huh...I find out that all header file has a strange white character after #endif
Comments from the review on Reviewable.io
vjudge-v2/UESTCJudger.cpp, line 171 [r1] (raw file): Done.
Comments from the review on Reviewable.io
Reviewed files:
vjudge-v2/GlobalHelpers.h, line 50 [r2] (raw file): space
Comments from the review on Reviewable.io