BNUACM / bnuoj-vjudge

Virtual Judge for BNUOJ
GNU Affero General Public License v3.0
13 stars 7 forks source link

fix NJUPT and update charset_convert #14

Closed crccw closed 9 years ago

crccw commented 9 years ago

Review on Reviewable

51isoft commented 9 years ago

vjudge-v2/AizuJudger.cpp, line 171 [r1] (raw file): So this is not buffer any more


vjudge-v2/GlobalHelpers.cpp, line 319 [r1] (raw file): Comment is wrong


vjudge-v2/GlobalHelpers.h, line 19 [r1] (raw file): remove


vjudge-v2/HDUJudger.cpp, line 190 [r1] (raw file): ditto


vjudge-v2/NJUPTJudger.cpp, line 187 [r1] (raw file): ditto



Comments from the review on Reviewable.io

crccw commented 9 years ago

vjudge-v2/AizuJudger.cpp, line 171 [r1] (raw file): my fault...


vjudge-v2/GlobalHelpers.cpp, line 319 [r1] (raw file): Done.


vjudge-v2/GlobalHelpers.h, line 19 [r1] (raw file): Done.


vjudge-v2/HDUJudger.cpp, line 190 [r1] (raw file): Done.


vjudge-v2/NJUPTJudger.cpp, line 187 [r1] (raw file): Done.



Comments from the review on Reviewable.io

51isoft commented 9 years ago

vjudge-v2/GlobalHelpers.cpp, line 325 [r2] (raw file): space-1



Comments from the review on Reviewable.io

crccw commented 9 years ago

vjudge-v2/GlobalHelpers.cpp, line 325 [r2] (raw file): Done.



Comments from the review on Reviewable.io