BOINC / boinc

Open-source software for volunteer computing and grid computing.
https://boinc.berkeley.edu
GNU Lesser General Public License v3.0
2.02k stars 446 forks source link

When adding an already-added project, "Already Added" dialog is not always shown. [Superlink@Technion] #1043

Open romw opened 9 years ago

romw commented 9 years ago

Reported by JacobKlein on 5 Mar 41245674 16:26 UTC For the Superlink@Technion project, if I'm already attached to it, and I try to attach to it again, I do not get the "already added" dialog. BOINC should not let me add it again.

Instead, BOINC bypasses the "Already Added" check, and proceeds to this dialog:

---------------------------[Manager[BR]---------------------------[project may not have work for your type of computer. Do you want to add it anyway?[BR]---------------------------[No [BR]---------------------------

I believe the dialog[project may not have work for your type of computer. Do you want to add it anyway?"[BR]is preventing the dialog[already added this project. Please choose a different project."[BR]from showing first properly.

Fortunately, I don't think there are severe consequences of adding the project again, as I'm not aware of any problems, but...[[BR]]The UI should not have allowed me to add this project twice.

Migrated-From: http://boinc.berkeley.edu/trac/ticket/1067

romw commented 9 years ago

Commented by JacobKlein on 5 Feb 41286147 05:46 UTC Further research indicates that the "may not have work for your type of computer" dialog may also be using the selected row as the project to check, even though the user may have pasted a URL.

For instance, if I paste this into the "Project URL" field: http://cbl-boinc-server2.cs.technion.ac.il/superlinkattechnion/ while leaving the row on AVC@home, I get the "already added" dialog.

However, if I click the "Spinhenge@home" row, then paste this into the "Project URL" field: http://cbl-boinc-server2.cs.technion.ac.il/superlinkattechnion/ , I get the "may not have work for your type of computer" dialog.

Clearly something is not being checked in the right order, and also, if the users pastes a URL, it's still using the select-row as the project to check. Both of these needs to be fixed.

ChristianBeer commented 7 years ago

I'm not sure if this is still the case, someone needs to find out I guess.

Ageless93 commented 7 years ago

The simplest solution would be to take the projects that are already added from the Add Project wizard list, or if that's not desired, at least give them a different colour.

But so far, I've gone through whole my list of projects and I cannot reproduce this on 7.6.33 (via BOINC Manager).

-- Jord van der Elst.

On Fri, Apr 7, 2017 at 1:43 PM, Christian Beer notifications@github.com wrote:

I'm not sure if this is still the case, someone needs to find out I guess.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/BOINC/boinc/issues/1043#issuecomment-292515455, or mute the thread https://github.com/notifications/unsubscribe-auth/AKXbU3XuCSCXmSy01NY3TbEnQbFd9WdIks5rtiFFgaJpZM4DbYY_ .

Ageless93 commented 7 years ago

Tested again with 7.8.3 and still cannot reproduce the problem. Is the topic starter (Jacob Klein) still seeing this problem?

AenBleidd commented 6 years ago

@JacobWKlein, did you see this issue last couple of years?

JacobWKlein commented 6 years ago

Hmm...

The behavior I'm seeing now, is that, the following already-attached-projects (via BOINCstats), are not correctly telling me that they've already been added, when trying to add through the UI. Examples below. It seems that we aren't properly filtering for http vs https, and also aren't properly handline URLs for climateprediction.net.

{Project} {Add Project URL} {Attached URL} {Result of attempt}

climateprediction.net http://www.cpdn.org/cpdnboinc/ https://climateprediction.net Failed to add project - Please try again later. Click Finish to close.

MindModeling@Home https://mindmodeling.org/ http://mindmodeling.org/ Failed to add project - Please try again later. Click Finish to close.

NFS@home https://escatter11.fullerton.edu/nfs/ escatter11.fullerton.edu/nfs/ Failed to add project - Please try again later. Click Finish to close.

Numberfields@home https://numberfields.asu.edu/NumberFields/ numberfields.asu.edu/NumberFields/ Failed to add project - Please try again later. Click Finish to close.

AenBleidd commented 6 years ago

Ok, I can agree with the case http/https but in case of climateprediction.net its URLs are different and including complicated logic to verify whether these URLs are belong to the same project is not nice way, I think

JacobWKlein commented 6 years ago

That's fair. I hope you can make a change.

RichardHaselgrove commented 6 years ago

That sounds more like a clash between an Account Manager and the basic BOINC GUI. (I assume you mean you're using BAM!, the account manager from the same stable as BOINCstats?). We should perhaps find a Science United user to check whether the problem is generic to all account manager interaction, or a specific BAM! bug.