BOINC / boinc

Open-source software for volunteer computing and grid computing.
https://boinc.berkeley.edu
GNU Lesser General Public License v3.0
2.04k stars 449 forks source link

RPMLINT: shared-lib-calls-exit #1074

Open romw opened 9 years ago

romw commented 9 years ago

Reported by saigkill on 3 Mar 41325904 11:06 UTC libboinc6.x86_64: W: shared-lib-calls-exit /usr/lib64/libboinc_api.so.6.10.58 exit@GLIBC_2.2.5

libboinc6.x86_64: W: shared-lib-calls-exit /usr/lib64/libboinc_graphics2.so.6.10.58 exit@GLIBC_2.2.5

This library package calls exit() or _exit(), probably in a non-fork() context. Doing so from a library is strongly discouraged - when a library function calls exit(), it prevents the calling program from handling the error, reporting it to the user, closing files properly, and cleaning up any state that the program has. It is preferred for the library to return an actual error code and let the calling program decide how to handle the situation.

Migrated-From: http://boinc.berkeley.edu/trac/ticket/1098

Ageless93 commented 7 years ago

Is this still an issue with a modern BOINC version?

computersalat commented 7 years ago

Yes it is:

[  182s] RPMLINT report:
[  182s] ===============
[  185s] libboinc7.x86_64: W: shared-lib-calls-exit /usr/lib64/libboinc_graphics2.so.7.8.2 exit@GLIBC_2.2.5
[  185s] This library package calls exit() or _exit(), probably in a non-fork()
[  185s] context. Doing so from a library is strongly discouraged - when a library
[  185s] function calls exit(), it prevents the calling program from handling the
[  185s] error, reporting it to the user, closing files properly, and cleaning up any
[  185s] state that the program has. It is preferred for the library to return an
[  185s] actual error code and let the calling program decide how to handle the
[  185s] situation.