search

BOINC / boinc

Open-source software for volunteer computing and grid computing.
https://boinc.berkeley.edu
GNU Lesser General Public License v3.0
2.03k stars 449 forks source link

[pre][/pre] containers in [code][/code] containers on BOINC forum code execute, instead of show the container codes #1381

Closed Ageless93 closed 4 months ago

Ageless93 commented 9 years ago

While teaching someone how to use all the tag containers, I added [pre] .. [/pre] in a code container ([code] .. [/code]) and found that it's executed inside the code container.

It shows as a code box, but then with 

<div class="pre">..</div>

in the post preview and in the post. I expect that it shows [pre]..[/pre] in the code container.

Is someone able to fix this?

ChristianBeer commented 7 years ago

Is still happening with bootstrap?

Ageless93 commented 7 years ago

Yep: https://boinc.berkeley.edu/dev/forum_thread.php?id=11565#77314

ChristianBeer commented 7 years ago

The interesting thing with your example is that [pre] gets translated to html but [url] not. This seems to be a problem with the bbcode2html parser which should ignore bbcode tags if they are inside [code] tags.

Ageless93 commented 7 years ago

As https://boinc.berkeley.edu/dev/forum_thread.php?id=11565&postid=77317#77317 shows, everything else works. Well, but for showing code tags within code tags, then the end code tag doesn't work. ;-)

As an aside, I can execute tags though, but not tags.

-- Jord van der Elst.

On Tue, Apr 11, 2017 at 6:06 PM, Christian Beer notifications@github.com wrote:

The interesting thing with your example is that [pre] gets translated to html but [url] not. This seems to be a problem with the bbcode2html parser which should ignore bbcode tags if they are inside [code] tags.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/BOINC/boinc/issues/1381#issuecomment-293312316, or mute the thread https://github.com/notifications/unsubscribe-auth/AKXbU2wMjxlEb1paYepPOiz8a6TE3A91ks5ru6TqgaJpZM4FqZ3o .

ChristianBeer commented 7 years ago

Ok, the problem is [pre] inside [code] gets translated to html while it should stay bbcode. This needs to be fixed.

The [code] within [code] does not work by design of the parser. I believe it's not worth fixing that particular problem. A workaround would be to use [code] within [pre] which should have the same effect (if not it's a bug again).

Ageless93 commented 7 years ago

Good idea. Hadn't thought of that. Yes, that works as normal, I did [pre][code][color=red]Red text[/color][/code][/pre] which just shows the middle, and shows it unexecuted.

That I can execute some HTML codes is because I have the administrator title. I'd like to keep being able to do that as it sometimes helps clearing up some code in a sentence, without having to use the cumbersome code boxes.

By the way, previewing any post with code in it shows the code tags as well, not executed, while it will show things like bold, strike through, italics and underline in executed form. That to do with the same parser? Or a separate issue I need to write a separate ticket for?

-- Jord van der Elst.

On Wed, Apr 12, 2017 at 8:50 AM, Christian Beer notifications@github.com wrote:

Ok, the problem is [pre] inside [code] gets translated to html while it should stay bbcode. This needs to be fixed.

The [code] within [code] does not work by design of the parser. I believe it's not worth fixing that particular problem. A workaround would be to use [code] within [pre] which should have the same effect (if not it's a bug again).

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/BOINC/boinc/issues/1381#issuecomment-293489684, or mute the thread https://github.com/notifications/unsubscribe-auth/AKXbUwWfhmHmMSpXCSN0sps6bkurWFN5ks5rvHRFgaJpZM4FqZ3o .

ChristianBeer commented 7 years ago

Ideally the same parser is used for preview and afterwards. I think that can be fixed together with the [code] tag issue.

davidpanderson commented 7 years ago

The same function (output_transform(), in text_transform.inc) is used for preview and final version.

On 4/12/2017 5:57 AM, Christian Beer wrote:

Ideally the same parser is used for preview and afterwards. I think that can be fixed together with the [code] tag issue.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/BOINC/boinc/issues/1381#issuecomment-293567338, or mute the thread https://github.com/notifications/unsubscribe-auth/AA8KgbD7oCcqxDXjsBryYwO3HDRG19Irks5rvMpFgaJpZM4FqZ3o.