Confirmation dialog on Defaults button (in Event log options...)

BOINC / boinc

Open-source software for volunteer computing and grid computing.

https://boinc.berkeley.edu

GNU Lesser General Public License v3.0

1.99k stars 443 forks source link

Confirmation dialog on Defaults button (in Event log options...) #2322

Open Ageless93 opened 6 years ago

Ageless93 commented 6 years ago

When clicking the Defaults button in the Event Log options... menu, there is now no confirmation dialog asking if I want to reset everything to default. We have confirmation dialogs on every other decision window, so there should be one here as well.

RichardHaselgrove commented 6 years ago

@AenBleidd - I think this is the ticket you were asking for.

AenBleidd commented 6 years ago

Yes, thank you. Sorry, I answered a wrong thread before.

JuhaSointusalo commented 6 years ago

The places with confirmation dialog that I could find are:

File -> Shut down connected client
File -> Exit BOINC Manager
Options -> Computing preferences -> Use web prefs
Options -> Select columns -> Defaults
Options -> Event Log options -> Defaults
Tools -> Add project / Use account manager -> Cancel

The difference between Event Log options and the rest are that the rest take effect immediately after confirmation. In Event Log options after clicking Defaults you can still choose between Save and Cancel. Asking for a confirmation when you can back out after the confirmation seems unnecessary to me.

RichardHaselgrove commented 6 years ago

There are several more - abort task, remove project, to list just two.

JuhaSointusalo commented 6 years ago

I didn't think of to try those. But the point still stands, those others take effect immediately too.

Ageless93 commented 6 years ago

The problem though is that you do not have any visual warning that you're about to reset the log flags to default. Not even the mouse-over specifically warns of this. The Options->Select columns->Defaults has the warning, while it also has the Save button. So why do it like that there then? Here clicking OK on the dialog sets the defaults immediately, without having to click Save.

I do think that in all these scenarios the Defaults button should have the warning dialog, plus on clicking OK on the warning dialog should immediately set the defaults, no need to separately click the Save button.

JuhaSointusalo commented 6 years ago

The Options->Select columns->Defaults has the warning, while it also has the Save button. So why do it like that there then?

Select columns -> Defaults implicitly clicks Save for you. You don't get a chance to change your mind so there needs to be the confirmation.

I do think that in all these scenarios the Defaults button should have the warning dialog, plus on clicking OK on the warning dialog should immediately set the defaults, no need to separately click the Save button.

If the Event Log -> Defaults is changed to implicitly click Save and close the dialog then it makes sense to have confirmation there too. That would unify user experience for the dialogs so that would work for me.