BOINC / boinc

Open-source software for volunteer computing and grid computing.
https://boinc.berkeley.edu
GNU Lesser General Public License v3.0
2k stars 445 forks source link

Recent commit to the BOINC Manager, to not enable stopping the BOINC client when configured as a systemd service, results in anomaly. #5601

Closed original-birdman closed 4 months ago

original-birdman commented 5 months ago

The commit is: https://github.com/BOINC/boinc/commit/82a4fc80613264b18f358963b76aeb4697deb8c5

This greys out (disables) the File/Shut down connected client.. option if BOINC is running as a systemd service on the current system.

This works, but produces an anomaly. I do not think it is working as intended. It is certainly not working in any logical manner.

The check is done on the local system. However, the same check is used (i.e against the local system) even when the Manager is connected to a remote system.

The result is that when I run the BOINC Manager on my Desktop system (which has BOINC running as a system service) it does not let me stop the client on any system. However, on my laptop (which isn't running any BOINC client) the option to stop the client is enabled when I connect to any remote system - including that Desktop system (the one where I cannot stop it when logged in locally).

I suspect that the option should always be disabled when connected to a remote system.

And I think there should be an option in the Manager code to enable the "Shut down" option for any connected, logged in client.