vboxwrapper: don't create projects/virtualbox

BOINC / boinc

Open-source software for volunteer computing and grid computing.

https://boinc.berkeley.edu

GNU Lesser General Public License v3.0

1.95k stars 439 forks source link

vboxwrapper: don't create projects/virtualbox #5658

Open davidpanderson opened 2 weeks ago

davidpanderson commented 2 weeks ago

If Vboxwrapper couldn't find the Vbox 'home dir' (normally ~/.VirtualBox) based on env vars, it would create one: projects/virtualbox (owned by boinc_projects, not boinc_master)

This is wrong because 1) on startup, the client deletes anything in projects/ that's not a project directory 2) on Mac it causes installer error messages because the dir is not owned by boinc_master.

Fix: don't create projects/virtualbox.

AenBleidd commented 2 weeks ago

@computezrmle, could you please review this change?

computezrmle commented 2 weeks ago

The docs mention different directories to put VirtualBox.xml in depending on the host OS:

Linux and Oracle Solaris:$HOME/.config/VirtualBox.
Windows:$HOME/.VirtualBox.
macOS:$HOME/Library/VirtualBox.

It looks like the patch covers the situation on Windows only.

On Linux and Oracle Solaris XDG_CONFIG_HOME can be used instead of VBOX_USER_HOME. This case may also be implemented.

davidpanderson commented 2 weeks ago

Other than the comment, is the change OK?