Closed davidpanderson closed 3 weeks ago
Attention: Patch coverage is 0%
with 66 lines
in your changes missing coverage. Please review.
Project coverage is 10.75%. Comparing base (
26ce93e
) to head (63ef5f1
). Report is 11 commits behind head on master.
Files with missing lines | Patch % | Lines |
---|---|---|
sched/plan_class_spec.cpp | 0.00% | 33 Missing :warning: |
lib/wslinfo.cpp | 0.00% | 17 Missing :warning: |
lib/util.cpp | 0.00% | 9 Missing :warning: |
lib/cc_config.cpp | 0.00% | 5 Missing :warning: |
sched/sched_types.cpp | 0.00% | 2 Missing :warning: |
New philosophy: always query the presence of software (WSL distros, Docker) even if client config doesn't allow its use. Send the config info to scheduler, and enforce it there.
New philosophy: allow running jobs in any WSL distro except those disallowed in the config
Add plan class support for WSL and Docker app versions
client: query the libc version of WSL distros and report it in scheduler requests. The plan class entry for a WSL app version can specify a min libc version.
wsl_wrapper: add --min_libc_version cmdline arg (should match plan class spec)