search

BOINC / boinc

Open-source software for volunteer computing and grid computing.
https://boinc.berkeley.edu
GNU Lesser General Public License v3.0
2.03k stars 449 forks source link

web: parse gd version number correctly #5868

Closed davidpanderson closed 3 weeks ago

davidpanderson commented 3 weeks ago

We were checking specifically for '2.0'. If you had a later version (like 2.2) it would think you had an old version, and use an old image conversion function that produces wrong-colored results.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 10.75%. Comparing base (de57329) to head (60918aa). Report is 316 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5868 +/- ## ============================================ + Coverage 10.53% 10.75% +0.21% Complexity 1068 1068 ============================================ Files 279 280 +1 Lines 35875 36552 +677 Branches 8412 8471 +59 ============================================ + Hits 3780 3930 +150 - Misses 31701 32233 +532 + Partials 394 389 -5 ``` [see 120 files with indirect coverage changes](https://app.codecov.io/gh/BOINC/boinc/pull/5868/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BOINC)