BOLL7708 / OpenVR2Key

Simulates key presses from SteamVR input
120 stars 16 forks source link

v0.53 Chords will not release properly if order of combined keys are not reversed #9

Closed BOLL7708 closed 3 years ago

BOLL7708 commented 3 years ago

Title is a mess but I'm reporting this myself, as it has caused me a lot of problems, I will need to fix this.

Chords don't seem to release properly if I release the involved buttons in the same order I pressed them, instead of the opposite order which luckily is the intuitive way of doing it, which I think is why this issue has been sporadic at best.

Steps to reproduce

Notes

When using the Input Debugger in the settings, it can be seen that when flipping the order the input hand assignment also switches. It register CHORD IN on the Right hand but CHORD OUT on the Left hand, and I think this is something that I filter on in later version, as a friend with an old version does not get the same problem.

Fix

Clearly CHORDS specifically should not be filtered on Left/Right as that breaks if it's not the same hand that initiates and ends the chord activation.

BOLL7708 commented 3 years ago

Fixed in v0.54