search

BOSSoNe0013 / track-o-bot

The friendly Hearthstone Tracker (Linux port)
https://trackobot.com
GNU Lesser General Public License v2.1
39 stars 6 forks source link

Fixes double Quit in systray #28

Closed angrylinuxuser closed 8 years ago

angrylinuxuser commented 8 years ago

This fixes doube quit in systray i had since commit 2fd0328fe831d21704ffe4133681e2b2746dfe7d

Since getenv returns full path ( /usr/share/xsessions/plasma in this case ) we could match this string or use regexp to find plasma. I chose regexp since who knows if there is any other distro that may have different path to xsessions.

I bet there is a better way to handle this since my Qt experience is practically non-existent :)

BOSSoNe0013 commented 8 years ago

Thanks for the commit :)

BOSSoNe0013 commented 8 years ago

I've upgraded my system to Kubuntu 15.10 which is ship with KDE 5.15.0 and Qt 5.4.2 and it seems this solved the problem with duplicated Quit entry so now there's no-more Quit entry in the menu :( I think i'll remove the plasma check.

angrylinuxuser commented 8 years ago

im running arch with qt5.5 kde 5.15 and i had this issue. Dont know whats going on there :)

angrylinuxuser commented 8 years ago

if i remove those if linux and plasma checks it works fine for me (no double quit). ill check with other DE after ill get home since i got VM with gnome set up.

NVM i still have that.

angrylinuxuser commented 8 years ago

It apears it is related to kde somehow. I checked other qt5 apps and something is adding quit entry for every app. Strange since we have the same versions of kde frameworks(maybe kubuntu is patching thing but arch isnt). So it is a good idea to remove those plasma and linux checks since without them it works fine on ubuntu. However i could not get tray running on gnomeshell even with extensions for systemtray with or without that if block.

BOSSoNe0013 commented 8 years ago

i'll only comment the lines since i found more info. Thanks for the feedback.