search

BOSSoNe0013 / track-o-bot

The friendly Hearthstone Tracker (Linux port)
https://trackobot.com
GNU Lesser General Public License v2.1
39 stars 6 forks source link

Linux: Remove mask from overlay #69

Closed MannyC closed 7 years ago

MannyC commented 7 years ago

Depending on screen size the mask being set doesn't gel with where the paint code tries to paint, resulting in a clipped overlay. Also, the minimum width of 200 is computed but never used.

However, I can't currently see what it's useful for. Why clip it at all rather than just not paint where you don't want to paint? Does qt not deal with this well?

It was introduced in https://github.com/BOSSoNe0013/track-o-bot/commit/9b4222a457154babd4878855787021990ba50c3f, but there isn't any specific reasoning given so the original logic may no longer apply?

Removing it fixes the overlay on my 1600x1200 window, which was previously clipped.

angrylinuxuser commented 7 years ago

To be honest i remove it also in my own repo. I think that mask should go away :)