adamwadelewis
commented
2 years ago Update
Problem 1: OK, Problem 2: Test cases need more work (-5 pts) Problem 3: Incomplete solution (-20 pts).
Open adamwadelewis opened 2 years ago
adamwadelewis
commented
2 years ago Problem 1: OK, Problem 2: Test cases need more work (-5 pts) Problem 3: Incomplete solution (-20 pts).
A note about using Git and GitHub
Think a bit about how you need to use the version control stuff. What I saw in the repository is that you did all of the work and then checked in finished product when you were ready to submit. That means you aren't taking advantage of the some the helpful features that Git gets you for building and working with code.
Folder structures
Remember what it is that we are doing as the overall project in this class: building a set of class libraries. That's why you have that apps/doc/inlcude split between the different folders in the starter code. Header files for classes need to be concentrated into a central folder that you access from other places. If you're not wanting to use the folder structure and cmake build system provided in the sample code, you should put the header files into one folder and adjust the project files you're using to include that folder in your include path. Contact me if you need more information on how to do that.
Gradable things:
Problem 1: OK. Problem 2: Think a bit more about your test cases. What can break? When would something break? Example: what happens when I try to pop an item out of empty list? (-5 pts). Problem 3: Didn't find any indication in your repository of where you did this. (-30 pts).