Closed dr-orlovsky closed 1 year ago
Attention: 67 lines
in your changes are missing coverage. Please review.
Files | Coverage Δ | |
---|---|---|
consensus/src/stl.rs | 96.8% <ø> (-0.1%) |
:arrow_down: |
consensus/src/util.rs | 0.0% <ø> (-6.1%) |
:arrow_down: |
dbc/src/tapret/tx.rs | 92.3% <100.0%> (+0.5%) |
:arrow_up: |
dbc/src/tapret/xonlypk.rs | 98.1% <100.0%> (-0.2%) |
:arrow_down: |
seals/src/txout/error.rs | 25.0% <ø> (ø) |
|
src/stl.rs | 100.0% <ø> (ø) |
|
consensus/src/coding.rs | 85.0% <0.0%> (ø) |
|
seals/src/txout/witness.rs | 0.0% <0.0%> (ø) |
|
consensus/src/taproot.rs | 43.3% <12.5%> (+0.3%) |
:arrow_up: |
consensus/src/segwit.rs | 16.9% <8.3%> (ø) |
|
... and 2 more |
:loudspeaker: Thoughts on this report? Let us know!.
This adds final API-breaking changes from todos for the release:
InternalPk
type (which breaks semantic library id and thus is "breaking")Chain
type which is an ambiguous data structure - we added support for Liquid in other LNP/BP libraries, but this library is dedicated to Bitcoin only; thus there are no other chains which can be defined here.Chain
was operating as a way to select specific testnet - but this task must be done in the wallet-libraries and not in the consensus library.