search

BP-WG / bp-core

BP Core Lib: consensus data structures and client-side-validation library for bitcoin protocol
Apache License 2.0
23 stars 20 forks source link

Make Anchor consensus-only data (remove txid) #84

Closed dr-orlovsky closed 6 months ago

dr-orlovsky commented 7 months ago

This is the alternative to https://github.com/BP-WG/bp-core/pull/83 removing non-consensus data from Anchors and achieving the same goal by just delegating SPV storage and verification outside of this library.

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 47.7%. Comparing base (7b1ff00) to head (c014bad).

Files Patch % Lines
seals/src/txout/witness.rs 0.0% 3 Missing :warning:
dbc/src/anchor.rs 0.0% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #84 +/- ## ======================================== - Coverage 48.2% 47.7% -0.5% ======================================== Files 36 34 -2 Lines 3290 3149 -141 ======================================== - Hits 1587 1503 -84 + Misses 1703 1646 -57 ``` | [Flag](https://app.codecov.io/gh/BP-WG/bp-core/pull/84/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BP-WG) | Coverage Δ | | |---|---|---| | [rust](https://app.codecov.io/gh/BP-WG/bp-core/pull/84/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BP-WG) | `47.7% <60.0%> (-0.5%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BP-WG#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.