BP-WG / bp-std

Modern & lightweight implementation of bitcoin standards without rust-bitcoin/miniscript dependencies
Apache License 2.0
16 stars 17 forks source link

make PropKey methods public #20

Closed zoedberg closed 6 months ago

zoedberg commented 6 months ago

This PR makes PropKey::mpc_entropy() public, needed to avoid manually recreating the proprietary key using constants before converting it to a rust-bitcoin proprietary key.

codecov[bot] commented 6 months ago

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (28d3228) 0.0% compared to head (48df55f) 0.0%.

Files Patch % Lines
psbt/src/csval/mpc.rs 0.0% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #20 +/- ## ===================================== Coverage 0.0% 0.0% ===================================== Files 17 17 Lines 3157 3157 ===================================== Misses 3157 3157 ``` | [Flag](https://app.codecov.io/gh/BP-WG/bp-std/pull/20/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BP-WG) | Coverage Δ | | |---|---|---| | [rust](https://app.codecov.io/gh/BP-WG/bp-std/pull/20/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BP-WG) | `0.0% <0.0%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BP-WG#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

zoedberg commented 6 months ago

Ok, I will update the PR then

zoedberg commented 6 months ago

Done