search

BP-WG / bp-std

Modern & lightweight implementation of bitcoin standards without rust-bitcoin/miniscript dependencies
Apache License 2.0
16 stars 17 forks source link

PSBT support for deterministic bitcoin commitments (tapret and opret) #9

Closed dr-orlovsky closed 8 months ago

dr-orlovsky commented 8 months ago

Finally completed the work on doing everything necessary for DBCs and MPCs in PSBTs. This is prerequisite for completing RGB support in PSBT and last bit of RGB wallet functionality

codecov[bot] commented 8 months ago

Codecov Report

Attention: 474 lines in your changes are missing coverage. Please review.

Comparison is base (a200597) 52.7% compared to head (45841a7) 0.0%.

:exclamation: Current head 45841a7 differs from pull request most recent head fe14cda. Consider uploading reports for the commit fe14cda to get more accurate results

Files Patch % Lines
psbt/src/csval/mpc.rs 0.0% 140 Missing :warning:
psbt/src/data.rs 0.0% 76 Missing :warning:
psbt/src/csval/tapret.rs 0.0% 75 Missing :warning:
psbt/src/csval/opret.rs 0.0% 50 Missing :warning:
psbt/src/maps.rs 0.0% 49 Missing :warning:
psbt/src/csval/dbc.rs 0.0% 45 Missing :warning:
derive/src/taptree.rs 0.0% 16 Missing :warning:
derive/src/path.rs 0.0% 14 Missing :warning:
derive/src/derive.rs 0.0% 6 Missing :warning:
psbt/src/coders.rs 0.0% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #9 +/- ## ======================================== - Coverage 52.7% 0.0% -52.7% ======================================== Files 20 17 -3 Lines 2849 3143 +294 ======================================== - Hits 1501 0 -1501 - Misses 1348 3143 +1795 ``` | [Flag](https://app.codecov.io/gh/BP-WG/bp-std/pull/9/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BP-WG) | Coverage Δ | | |---|---|---| | [rust](https://app.codecov.io/gh/BP-WG/bp-std/pull/9/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BP-WG) | `0.0% <0.0%> (-52.7%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BP-WG#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dr-orlovsky commented 8 months ago

Can you check to see if these changes affect the ~250,000 MPC contract limit?

I will, but I do not see in any way how they can be affected by this code. It is BP library, not RGB, it has nothing to do with contracts. It just follows Bitcoin consensus and BIPs - that's it

dr-orlovsky commented 8 months ago

I will, but I do not see in any way how they can be affected by this code. It is BP library, not RGB, it has nothing to do with contracts. It just follows Bitcoin consensus and BIPs - that's it

Sorry, wrong repo. Yes, the part you commented on is about DBCs and thus related to RGB contracts. But there is nothing which can affect it since the work is done in commit_verify repository and not here. We can't restrict it to the level of a standard library, it doesn't deal with the concept of the validity of commitments and trees and is just a helper tool to construct them (there can be more different tools in the future).

It is like libwally can't restrict the way Bitcoin consensus works

cryptoquick commented 8 months ago

I see. This is high level and wouldn't affect consensus beyond what's specified in this library. I think I'm also confused, thank you for the clarification.