search

BP-WG / bp-wallet

Modern, lightweight & standard-compliant bitcoin wallet runtime & cli without rust-bitcoin dependencies
Apache License 2.0
17 stars 12 forks source link

test round trip #74

Closed patrix252 closed 2 weeks ago

patrix252 commented 1 month ago

This PR adds some simple tests to check that string round-trip conversion of all objects implementing from_str works fine.

In addition, I've also formatted the code with cargo +nightly fmt --all.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 4.9%. Comparing base (784ff20) to head (8ed740f). Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #74 +/- ## ======================================= + Coverage 0.0% 4.9% +4.9% ======================================= Files 24 24 Lines 2259 2315 +56 ======================================= + Hits 0 113 +113 + Misses 2259 2202 -57 ``` | [Flag](https://app.codecov.io/gh/BP-WG/bp-wallet/pull/74/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BP-WG) | Coverage Δ | | |---|---|---| | [rust](https://app.codecov.io/gh/BP-WG/bp-wallet/pull/74/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BP-WG) | `4.9% <100.0%> (+4.9%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BP-WG#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dr-orlovsky commented 4 weeks ago

Thank you very much and congrats with the first time contribution!

Re cargo fmt, this is a new nightly version which once again changed rules with no notice. I will fix it by using edition_style new option in cargofmt.toml and will ask you to rebase after.

dr-orlovsky commented 2 weeks ago

I have merged fmt changes and now you can just skip formatting commit. After that I will be able to merge this PR. Thank you!